Repository navigation
Fix line break handling for fractured json formatting - #2870
Merged
Merged
Conversation
This way we know the current depth to take the correct layout decision
Contributor
Author
|
Also I wasn't sure if every commit should update the amalgation via the script or when this is done |
Member
No. We refresh on release or periodically, but not on every commit. |
Member
|
Running tests. |
lemire
added a commit
that referenced
this pull request
Sep 22, 2026
…-Wmaybe-uninitialized GCC 11.4 (Ubuntu 22.04 CI, Debug/-Og developer build with -Werror) reports a false-positive 'v may be used uninitialized' on the json_sequence subtest since #2870 landed on top of #2872. The variable is only read after get(v) returned SUCCESS, so this is purely a diagnostic issue; the warning flips on unrelated call-graph changes in headers pulled in via simdjson.h. Initialize all the int64_t v locals in the file so the other identical sites cannot start failing the same way later.
lemire
added a commit
that referenced
this pull request
Sep 22, 2026
…-Wmaybe-uninitialized (#2875) GCC 11.4 (Ubuntu 22.04 CI, Debug/-Og developer build with -Werror) reports a false-positive 'v may be used uninitialized' on the json_sequence subtest since #2870 landed on top of #2872. The variable is only read after get(v) returned SUCCESS, so this is purely a diagnostic issue; the warning flips on unrelated call-graph changes in headers pulled in via simdjson.h. Initialize all the int64_t v locals in the file so the other identical sites cannot start failing the same way later.
Contributor
Author
|
@lemire what about table formatting? Is the goal to behave similar to Fractured JSON or what is the goal? |
Member
|
@maxbachmann Yes, we should be Fractured JSON compliant ? Whatever this might mean? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings formatting a lot closer to https://github.com/j-brooke/FracturedJson/wiki by fixing a bunch of issues with the handling of the line break calculation.
Type of change
There is another big topic this doesn't touch yet which is table formatting. This has severe issues but I wasn't sure whether we essentially want to handle them close to the original Fractured Json:
For me this handling in the original FracturedJson works quite well, but I wanted to make sure this is what we want here before making the change since it's a slightly larger change.