Conversation
svenssonaxel
suggested changes
Jan 27, 2025
svenssonaxel
left a comment
svenssonaxel
left a comment
There was a problem hiding this comment.
@lemire You might want to git add LICENSE-MIT. Apart from that it looks great.
Member
Author
|
@svenssonaxel Missing file added. |
svenssonaxel
approved these changes
Jan 27, 2025
Member
|
I am on board with the dual license for the project. And some I imagine it legally needs to be said, am fine with my code bring under the dual license. |
Member
|
Assuming that there's any of my code still in there (which given the
extensive and excellent development and refactoring may or may not be
true), I'm also OK with dual licensing in thus fashion.
…On Tue, 28 Jan 2025, 11:05 am John Keiser, ***@***.***> wrote:
I am on board with the dual license for the project. And some I imagine it
legally needs to be said, am fine with my code bring under the dual license.
—
Reply to this email directly, view it on GitHub
<#2328 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI3IUC23KCTAHFD7RJB7ODT2M3CVTAVCNFSM6AAAAABV6ZV6ZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJXGIZDQOJTGM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Member
Author
|
Thanks! |
svenssonaxel
added a commit
to svenssonaxel/rondb
that referenced
this pull request
Jan 28, 2025
This version of simdjson adds MIT as a dual license in order to help RonDB. simdjson/simdjson#2326 simdjson/simdjson#2328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds MIT licensing to help the RonDB to include simdjson in their project.
Fixes #2326