Enabling PPC64 (was always disabled by default)#2320
Merged
Conversation
lemire
changed the title
kth5
reviewed
Aug 12, 2025
| #elif defined(__PPC64__) || defined(_M_PPC64) | ||
| #define SIMDJSON_IS_PPC64 1 | ||
| #if defined(__ALTIVEC__) | ||
| #define SIMDJSON_IS_PPC64_VMX 1 |
There was a problem hiding this comment.
This isn't necessarily true, what you are assuming here is that you are using POWER7 or later locking out all earlier systems. VSX - which I assume is meant here? - was introduced in Power ISA v2.06 which was first implemented in POWER7.
Perhaps this is intentional but a damn shame for G5 users etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.