Allow some iterators to be used in standard C++ iterator functions#2106
Merged
lemire merged 1 commit intosimdjson:masterfrom Feb 5, 2024
Merged
Allow some iterators to be used in standard C++ iterator functions#2106lemire merged 1 commit intosimdjson:masterfrom
lemire merged 1 commit intosimdjson:masterfrom
Conversation
Member
|
Running tests. |
Contributor
Author
|
Whoops forgot to |
Contributor
Author
|
Also rebased on master which should stop the whitespace check from failing. |
Member
|
Running tests. |
Member
|
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some iterators are implemented to be like
std::iteratorbut don't actually allow themselves to be used wherestd::iteratorcan usually be used, because of some missing trait information. This PR adds that information.I've not touched
simdjson::ondemand::{array,object}_iteratoras I don't think these can be valid standard iterators given theMUST ONLY BE CALLED ONCE PER ITERATIONcomment foroperator*.