Skip to content

fix: updated filepath to sample-report#148

Merged
silverhack merged 1 commit intosilverhack:mainfrom
picccard:fix/unix-path-sample-report
Jun 12, 2025
Merged

fix: updated filepath to sample-report#148
silverhack merged 1 commit intosilverhack:mainfrom
picccard:fix/unix-path-sample-report

Conversation

@picccard
Copy link
Contributor

@picccard picccard commented Jun 10, 2025

Context

Mentioned in #147:

... after having a quick look around I've noticed a bug in the nav/file name. Unix paths are case sensitive, so the sample page doesn't load, as the file name in the nav/the file itself isn't correct. ...

- Sample Report: sample/monkey365.html

https://silverhack.github.io/monkey365/sample/monkey365.html
https://silverhack.github.io/monkey365/sample/Monkey365.html

Description

PR fixes the link. Thank you @kamilkrzyskow ❤️

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kamilkrzyskow
Copy link

Actually, in this commit the name was changed to lowercase. So I guess the file name should be changed to match the nav entry, as all nav entries are lowercase.

However, the mixed-case file name is mentioned in a PowerShell script:

$outFile = ("{0}{1}Monkey365.html" -f $outDir, [System.IO.Path]::DirectorySeparatorChar)

So I guess this would be overwritten later on with mixed-case again. So maybe the PowerShell file should also be changed to keep all of the names lowercase?

Perhaps, I've jumped the gun with this one yet again 👀 and opened another can of worms.
Sorry about the chaos ✌️

@picccard
Copy link
Contributor Author

Either the scripts have to output monkey365.html, all lower-case. Or mkdocs.yml have to expect the file to be upper-case.

https://github.com/search?q=repo%3Asilverhack%2Fmonkey365%20Monkey365.html&type=code


$outFile = ("{0}{1}Monkey365.html" -f $outDir, [System.IO.Path]::DirectorySeparatorChar)

$outFile = ("{0}{1}Monkey365.html" -f $outDir, [System.IO.Path]::DirectorySeparatorChar)

@silverhack
Copy link
Owner

Hey, thank you both for catching that! it's really appreciated. I'll review it asap and will merge with the main/dev branch. Additionally I'll review the code to lower as much as possible all outputs and/or to add toLower()/toUpper() utilities to maintain support across Windows/Linux.

Thanks!

@silverhack silverhack merged commit 177448f into silverhack:main Jun 12, 2025
@picccard picccard deleted the fix/unix-path-sample-report branch June 12, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants