Skip to content

feat: automatically format copyright string in footer with current year#147

Merged
silverhack merged 3 commits intosilverhack:mainfrom
picccard:feat/auto-upd8-footer-cc-year
Jun 12, 2025
Merged

feat: automatically format copyright string in footer with current year#147
silverhack merged 3 commits intosilverhack:mainfrom
picccard:feat/auto-upd8-footer-cc-year

Conversation

@picccard
Copy link
Contributor

Context

Currently the docs use a hardcoded year in the footer, this PR automatically inserts the current year.

Description

Method shared by @kamilkrzyskow in this discussion: How to add the year automatically in the copyright part

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kamilkrzyskow
Copy link

kamilkrzyskow commented Jun 10, 2025

[redacted] 🤦 Now I'm embarrassed 😳 , after pressing send I've realized that the commit also update to the bottom, so it seems it's been too long since I've worked with a PR 😆
So I was wrong, sorry about the confusion if you got an email.

081c0c7 adds an empty line to mkdocs.yml file, likely due to auto formatting.

Normally, I wouldn't comment on such stuff, however I haven't heard about this project before, and after having a quick look around I've noticed a bug in the nav/file name. Unix paths are case sensitive, so the sample page doesn't load, as the file name in the nav/the file itself isn't correct. Therefore, maybe it's worth it to revisit the PR before merging ✌️

- Sample Report: sample/monkey365.html

https://silverhack.github.io/monkey365/sample/monkey365.html
https://silverhack.github.io/monkey365/sample/Monkey365.html

Thanks for mentioning me and the discussion board over at mkdocs-material @picccard ❤️

@picccard
Copy link
Contributor Author

All good 😄 Thank you both for sharing your hook and pointing this out 🙌

@silverhack
Copy link
Owner

Hi all, many thanks for this. I'll review it as soon as possible and I'll perform updates to both main/dev branches.

Thanks!

@silverhack silverhack merged commit 94683a3 into silverhack:main Jun 12, 2025
@picccard picccard deleted the feat/auto-upd8-footer-cc-year branch June 12, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants