Add docker-compose merge file for production build #1822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the default docker-compose.yml file to build the development build, but allow passing an extra `-f` flag to docker compose in order to build the production build instead.
rmunn
added
the
engineering
Unit Test Results362 tests 362 ✅ 13s ⏱️ Results for commit 02a1e51. ♻️ This comment has been updated with latest results. |
hahn-kev
reviewed
May 29, 2024
The docker-compose.production.yml file already defines the ENVIRONMENT build arg (and env var) everywhere required, so the command-line arg to docker compose is now redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1821
Description
This will allow the default docker-compose.yml file to build the development build, but allow passing an extra
-fflag to docker compose in order to build the production build instead. (This is the Docker Compose equivalent of kustomize, though a little easier to use and understand than kustomize).Screenshots
Demonstrate any UI / behavioral changes with screenshots or animations.
Checklist
Testing
Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.
Describe how to verify your changes and provide any necessary test data.
docker compose buildsteps to include-f docker-compose.yml -f docker-compose.production.ymland make sure running variousmakecommands still works.