Get rid of symfony-exceptions.patch #1815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can finally get rid of this since it seems PHP exceptions are finally deriving from the Exception class rather than the Error class.
rmunn
added
the
engineering
Unit Test Results362 tests 362 ✅ 13s ⏱️ Results for commit e685f1d. ♻️ This comment has been updated with latest results. |
megahirt
requested changes
May 21, 2024
Collaborator
megahirt
left a comment
megahirt
left a comment
There was a problem hiding this comment.
How about we just comment out this feature instead of removing it. That way we can still use it when debugging PHP and need to see what the internal Error is.
This way we can easily re-apply the patch if need be. Also comment the commented-out lines so it's clear why they exist.
Collaborator
Author
|
@megahirt - Done. I've brought the patch file back, and simply commented out the lines in the Dockerfile that would apply it. So if this exception-swallowing behavior comes back in the future, it'll be obvious from reading the Dockerfile what to do about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1814
Description
We can finally get rid of this hacky "patch a vendor library in place" solution now that PHP exceptions are deriving from the Exception class rather than the Error class.
Screenshots
None; no behavior change.
Checklist
Testing
Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.
Describe how to verify your changes and provide any necessary test data.
makeand make sure the site still works.MONGODB_PASSenv var to an incorrect value to see an exception when you try to go to http://localhost:8080/auth/login