Base php 7.4 #1812
Merged
Base php 7.4 #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we will no longer attempt further PHP upgrades. Staying at PHP 7.4
megahirt
added
the
engineering
Unit Test Results362 tests 362 ✅ 13s ⏱️ Results for commit a62b4f9. ♻️ This comment has been updated with latest results. |
mongodb-org-tools is required for the backup/restore project command being added to the PHP application
Collaborator
Author
|
This PR tests are not expected to pass because we are changing back to the |
- move composer install into base-php image - xdebug 3.1 in both test and development app image
megahirt
commented
May 20, 2024
rmunn
approved these changes
May 20, 2024
Collaborator
rmunn
left a comment
rmunn
left a comment
There was a problem hiding this comment.
LGTM. One concern about the composer extension, but I don't think that should delay getting this merged into develop; we can back that one change out later if needed.
mongodb doesn't install on arm64 images of this type
rmunn
reviewed
May 20, 2024
Co-authored-by: Robin Munn <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to update the base-php image to 7.4. We will not update to future PHP versions, so it makes sense to just name this base-php
We also add the mongodb-org-tools apt package to the base-php image for use in the backup/restore planned task.
Once this is merged, I can manually create a new base-php image via GHA.
TODO:
make build-base-phplocallymakelocallymongoexportis available in the running app containerPHP tests complete successfully on my local machine, but will fail in this PR build since base-php hasn't been built properly until this is merged.
