Skip to content

Conversation

@rmunn
Copy link
Collaborator

@rmunn rmunn commented Nov 3, 2023

Fixes #1774

Description

Add a button to reset the browser storage cache, in case users need to (e.g., an interrupted download of the project dictionary).

Screenshots

image

Checklist

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

Testing

Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.

  • Go to a project's Configuration options
  • Go to the advanced configuration tab
  • Open Developer Tools, look at Local Storage in Application tab
  • Verify there are entries and comments
  • Click the red "Reset browser storage" button
  • Verify the entries and comments are gone from local storage

rmunn added 2 commits November 2, 2023 15:43
Added a button to the Advanced Configuration section to clear the
storage cache, and a short paragraph explaining what it does and why and
when one might want to do that.
@rmunn rmunn added the feature A improvement or feature label Nov 3, 2023
@github-actions
Copy link

github-actions bot commented Nov 3, 2023

Unit Test Results

362 tests   362 ✔️  13s ⏱️
  37 suites      0 💤
    1 files        0

Results for commit 80edf54.

♻️ This comment has been updated with latest results.

rmunn added 3 commits November 7, 2023 16:22
Instead of auto-reloading with location.reload, which doesn't seem to be
working as expected, just issue a Javascript alert to notify the user to
refresh the page.
rmunn added 2 commits November 8, 2023 10:41
The <a href="#"> element was being treated as a link back to the project
main page, which was not what I wanted.
This seems to be the best UX in the end.
@rmunn rmunn merged commit 1b8ddeb into develop Nov 9, 2023
@rmunn rmunn deleted the feature/reset-cache-button branch November 9, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A improvement or feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interupting loading the dictionary the first time leaves users in a state they can't recover from

4 participants