attempt additional prettier checks on PR builds #1778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megahirt
added
the
engineering
megahirt
force-pushed
the
chore/debugPrettier
branch
3 times, most recently
from
644d21c to
213f218
Compare
I have observed failing code formatting checks on CI that don't fail locally for v2.7.
megahirt
force-pushed
the
chore/debugPrettier
branch
from
213f218 to
5e0d200
Compare
myieye
approved these changes
Oct 2, 2023
Collaborator
myieye
left a comment
myieye
left a comment
There was a problem hiding this comment.
Interesting and slightly mysterious. Your changes certainly look like an improvement. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have observed failing code formatting checks
on CI that don't fail locally, e.g. #1777 had a failed code formatter check. Attempting to get more info with this PR.