Treat missing isDeleted field as false #1772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where missing isDeleted field was causing users to *not* show up in active-user lists.
megahirt
requested changes
Sep 15, 2023
Collaborator
megahirt
left a comment
megahirt
left a comment
There was a problem hiding this comment.
Thanks for fixing this, Robin. It looks like it just needs single quotes. Also needs testing as I didn't try and test the change.
Co-authored-by: Christopher Hirt <[email protected]>
Collaborator
Author
|
Code formatting check is failing on three SCSS files not touched in this PR. All other checks passing now that Chris caught the single-quotes issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where missing isDeleted field was causing users to not show up in active-user lists.
Fixes #1770.