Bug: remove new lines from multitext #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahn-kev
approved these changes
Jun 28, 2023
src/angular-app/bellows/shared/audio-recorder/audio-recorder.component.ts
Outdated
Show resolved
Hide resolved
myieye
force-pushed
the
bug/remove-new-lines-from-multitext
branch
from
aaf4f5b to
09e79ec
Compare
|
Hi there, Sorry for the late reply. Will this remove or prevent the creation of new lines globally? There are some fields like the Notes fields that should (I think) allow for new lines. For example, some printscreens from my lexicon: FLEX: LF PWA on Windows: LF on Android: Screen shots taken just now. Thanks |
Collaborator
Author
|
@alex-larkin I think it will only affect fields that are 1-line fields in FLEx. |
|
Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multi-texts were changed to
textareaelements at some point, in order to support line wrapping. However, that also allows them to support line-breaks. There seemed to be some logic for values that are supposed to be single-line, but line breaks were not being removed, so this fixes that.Additionally, I've added a simple log to see what the sample rate is for recordings on my phone. For some reason, I can't record audio when I access the app on my laptop from my phone, but I can when I access it on languageforge.org 🤷.