Bug: Project activity on dashboard sometimes triggers internal error #1760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1759
Description
The culprit of the Internal Error was PHP's
uasort, which we were using to sort activity leaving indices in place. Leaving indices in places potentially makes the array incompatible of being serialized as a JSON array. We don't care about the indices, so they can be tossed usingusortinstead.Additionally:
Almost removed the sorting by username before time functionality, but...maybe it's useful and I made enough changes 🤷.
There are no indications that the list is not truly chronological and a truly chronological sort seems more compatible with real-time collaboration.
Yup, I see now that the original code uses tabs and I used spaces.
Screenshots
Checklist
I have added tests that prove my fix is effective or that my feature worksTesting
Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.