Skip to content

Fix create memory mapped linux #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
papeh merged 3 commits into from
Sep 12, 2023
Merged

Fix create memory mapped linux #287

papeh merged 3 commits into from
Sep 12, 2023

Conversation

@hahn-kev
Copy link
Contributor

@hahn-kev hahn-kev commented Sep 11, 2023 •
edited by ddaspit
Loading

my previous PR #272 (related to #270) introduced a bug so that calling CreateOrOpen on linux would throw this error:

Putting project 'kjj-flex' on hold due to unhandled exception: 
System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
   at System.IO.Path.Combine(String path1, String path2)
   at SIL.LCModel.Infrastructure.Impl.SharedXMLBackendProvider.CreateOrOpen(String name, Int64 capacity, Boolean createdNew)
   at SIL.LCModel.Infrastructure.Impl.SharedXMLBackendProvider.CreateSharedMemory(Boolean createdNew)
   at SIL.LCModel.Infrastructure.Impl.SharedXMLBackendProvider.StartupInternal(Int32 currentModelVersion)
   at SIL.LCModel.Infrastructure.Impl.BackendProvider.StartupInternalWithDataMigrationIfNeeded(IThreadedProgress progressDlg)
   at SIL.LCModel.Infrastructure.Impl.BackendProvider.StartupExtantLanguageProject(IProjectIdentifier projectId, Boolean fBootstrapSystem, IThreadedProgress progressDlg)
   at SIL.LCModel.LcmCache.<>c__DisplayClass12_0.<CreateCacheFromExistingData>b__0(IDataSetup dataSetup)
   at SIL.LCModel.LcmCache.CreateCacheInternal(IProjectIdentifier projectId, String userWsIcuLocale, ILcmUI ui, ILcmDirectories dirs, LcmSettings settings, Action`1 doThe, Action`1 initialize)
   at SIL.LCModel.LcmCache.CreateCacheFromExistingData(IProjectIdentifier projectId, String userWsIcuLocale, ILcmUI ui, ILcmDirectories dirs, LcmSettings settings, IThreadedProgress progressDlg)
   at LfMerge.Core.FieldWorks.FwProject.TryGetLcmCache() in /home/builder/repo/src/LfMerge.Core/FieldWorks/FwProject.cs:line 97
   at LfMerge.Core.FieldWorks.FwProject..ctor(LfMergeSettings settings, String database) in /home/builder/repo/src/LfMerge.Core/FieldWorks/FwProject.cs:line 31
   at LfMerge.Core.LanguageForgeProject.get_FieldWorksProject() in /home/builder/repo/src/LfMerge.Core/LanguageForgeProject.cs:line 93
   at LfMerge.Core.Actions.TransferMongoToLcmAction.DoRun(ILfProject project) in /home/builder/repo/src/LfMerge.Core/Actions/TransferMongoToLcmAction.cs:line 53
   at LfMerge.Core.Actions.Action.Run(ILfProject project) in /home/builder/repo/src/LfMerge.Core/Actions/Action.cs:line 110
   at LfMerge.Core.Actions.SynchronizeAction.DoRun(ILfProject project) in /home/builder/repo/src/LfMerge.Core/Actions/SynchronizeAction.cs:line 64
   at LfMerge.Core.Actions.Action.Run(ILfProject project) in /home/builder/repo/src/LfMerge.Core/Actions/Action.cs:line 110
   at LfMerge.Program.RunAction(String projectCode, ActionNames currentAction) in /home/builder/repo/src/LfMerge/Program.cs:line 124

part of this was fixed in #280 however it missed a cleanup step that has been included here. It also only got merged into develop and not into master so that fix isn't in a released version anyway. This corrects that by merging into master.

This change is Reviewable

@hahn-kev hahn-kev force-pushed the fix-create-memory-mapped-linux branch from 1dea180 to 0a94adc Compare September 11, 2023 02:50
@hahn-kev
Copy link
Contributor Author

hahn-kev commented Sep 11, 2023

Did some digging, the build failure is due to an issue with dotnet 7.0.400 sdk, if we use a lower version it should work fine.

@papeh
Copy link
Contributor

papeh commented Sep 11, 2023

Did some digging, the build failure is due to an issue with dotnet 7.0.400 sdk, if we use a lower version it should work fine.

FieldWorks is still using .NET Framework 4.6.1 and no longer supporting Linux, so feel free to select the dotnet SDK that suits your team's needs.

@papeh papeh merged commit ef6fd57 into sillsdev:master Sep 12, 2023
@hahn-kev hahn-kev mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hahn-kev @papeh @ermshiperete