Fix NullReferenceError in SharedXMLBackendProvider under .Net Core on Linux #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #272 changed Platform.IsMono to IsUnix in the CreateOrOpen method, but the Platform.IsMono check in the constructor was missed. This fixes that omission.
Contributor
|
I asked @jasonleenaylor about this a while back and he insightfully pointed out that there is no point in LFMerge even invoking SharedXMLBackendProvider since it doesn't make sense in the server context, and that there was a way to tell liblcm to "turn if off" in a setting somewhere, but I don't know how to do that. So LFMerge is exercising this code when it's not actually useful to our purposes on the server. That's my understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #272 changed
Platform.IsMonotoIsUnixin theCreateOrOpenmethod of SharedXMLBackendProvider, but thePlatform.IsMonocheck in the constructor was missed. This fixes that omission, and will also fix sillsdev/LfMerge#323 (which was caused by the mismatch: when liblcm is running under .Net Core on Linux, as in LfMerge, the CreateOrOpen method ends up trying to use them_commitLogDirproperty that the constructor never set).This change is