use fallback for MemoryMappedFile.CreateOrOpen when not running on windows #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megahirt
approved these changes
Jan 16, 2023
Contributor
megahirt
left a comment
megahirt
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hahn-kev)
rmunn
added a commit
that referenced
this pull request
Apr 21, 2023
PR #272 changed Platform.IsMono to IsUnix in the CreateOrOpen method, but the Platform.IsMono check in the constructor was missed. This fixes that omission.
papeh
pushed a commit
that referenced
this pull request
Apr 21, 2023
PR #272 changed Platform.IsMono to IsUnix in the CreateOrOpen method, but the Platform.IsMono check in the constructor was missed. This fixes that omission.
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous pr #270 was merged into master instead of develop as it should have been.
This change is