Add webm as audio-file-type so it gets 10MB limit #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myieye
force-pushed
the
feature/10MB-webm-files
branch
from
1522fad to
a18a11f
Compare
ermshiperete
approved these changes
Jun 21, 2023
Contributor
|
one reason that webm might have not been included is that FLEx doesn't support it in all cases. There's some cases where a webm file is encoded using PCM audio (by the browser) and that encoding isn't supported as a webm file in FLEx. Because of this issue in the Combine we decided to convert webm files to wav when they were exported to FLEx. We might run into the same issue here where files will now get exported properly, and FLEx will see them, but still can't play them. |
Contributor
Author
|
@hahn-kev Interesting. Well, you could already send webm files to FLEx before this change. They just reverted to the default file size limit. All I did was increase the file size limit for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently increased the max file size for audio and images to 10MB.
But webm is a significant file format in the browser (i.e. Language Forge) and it's not included in the list of known audio file types, so recording audio in LF never actually benefited from this previous change 😲😢,
Webm is a file-type that FLEx supports, so there's no obvious reason to me why we shouldn't include it here, it was simply forgotten.
This change is