Skip to content

Conversation

@megahirt
Copy link
Contributor

@megahirt megahirt commented Nov 9, 2022

Fixes #277

This is in response to users who report a need to add audio and pictures to their project over 1MB in FLEx and Language Forge. The 1MB is reported to be too small.

Because we don't know practically how this will impact the majority of users, I am happy to introduce this change and evaluate the impact (pluses and minuses) on Language Forge and FLEx users who use Language Depot to collaborate, as well as the increased server storage needed to accommodate the higher limits.


This change is Reviewable

@megahirt megahirt self-assigned this Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Test Results

       4 files  ±0     119 suites  ±0   27m 53s ⏱️ - 1m 52s
   954 tests ±0     860 ✔️  - 3  79 💤 ±0  15 +3 
1 100 runs  ±0  1 005 ✔️  - 4  79 💤 ±0  16 +4 

For more details on these failures, see this check.

Results for commit d368d78. ± Comparison against base commit 327aa7e.

♻️ This comment has been updated with latest results.

This is in response to users who report a need to add audio and pictures to their project over 1MB.  The 1MB is reported to be too small.

Because we don't know practically how this will impact the majority of users, I am happy to introduce this change and evaluate the impact (plus/minus) on Language Forge and FLEx users who use Language Depot to collaborate.
Copy link
Contributor

@papeh papeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @megahirt)

@papeh papeh merged commit aa17de8 into master Dec 1, 2022
@papeh papeh deleted the feature/10MB branch December 1, 2022 22:39
papeh added a commit that referenced this pull request Dec 2, 2022
until unit tests can be fixed

This reverts commit aa17de8.
@megahirt
Copy link
Contributor Author

Hi @papeh, I'm confused about the workflow in this PR. It says that the PR was merged with failing unit tests (why was it merged?) but then the commit was later reverted "until unit tests can be fixed". Does this mean that the change is no longer in master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase 1-megabyte file size limit

3 participants