Use username & password (from env vars) for Mongo #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mongo connections can now use a username and password, specified by enviornment variables. If the environment variables are not present or are empty, then no authentication parameters are sent to Mongo.
6 tasks
megahirt
approved these changes
May 20, 2024
Contributor
megahirt
left a comment
megahirt
left a comment
There was a problem hiding this comment.
LGTM - Robin said he tested it locally
hahn-kev
reviewed
May 20, 2024
Collaborator
hahn-kev
left a comment
hahn-kev
left a comment
There was a problem hiding this comment.
cool! hopefully we can secure mongo soon
| var clientSettings = MongoClientSettings.FromConnectionString(connectionString); | ||
| // clientSettings.WriteConcern = WriteConcern.WMajority; // If increasing the wait queue size still doesn't help, try this as well | ||
| clientSettings.WaitQueueSize = 50000; | ||
| clientSettings.Server = new MongoServerAddress(Settings.MongoHostname, Settings.MongoPort); |
Collaborator
There was a problem hiding this comment.
is this line still relevant considering the port and host are in the connection string now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mongo connections can now use a username and password, specified by enviornment variables. If the environment variables are not present or are empty, then no authentication parameters are sent to Mongo.
Env vars used to specify the username and password will be
LFMERGE_MONGO_USERandLFMERGE_MONGO_PASS, matching the convention used for other LfMerge env vars.LFMERGE_MONGO_AUTHSOURCEcan also optionally be set to give the name of the MongoDB database where authentication is stored (default isadminand will probably not need changing).Part of sillsdev/web-languageforge#1787, but closing this PR should not close that issue. The linked PR in the LF repo will be the one to close that issue.