Skip to content

Conversation

@himanshus2025
Copy link

@himanshus2025 himanshus2025 commented Nov 20, 2025

Adding github action for building Linux kernel everytime , we make changes to kernel repo

@himanshus2025 himanshus2025 marked this pull request as draft November 20, 2025 09:55
@himanshus2025 himanshus2025 force-pushed the buildKernel branch 10 times, most recently from 9797542 to fbf954d Compare November 21, 2025 11:31
@himanshus2025 himanshus2025 marked this pull request as ready for review November 24, 2025 10:10
@shmuelhazan shmuelhazan requested review from astrunin and removed request for paul-sirin November 24, 2025 13:21
@astrunin
Copy link

Looks good to me.
I am not sure how I feel about having a copy of defconfig and device trees(and overlays) in there, but I am not sure if we have any options not to do this... Also, we are exposing our dts files and defconfig,
in that case why not to move them to our linux repo completely (maybe even with defconfig)? @shmuelhazan . As an upside we will not have to mainain it in two places...

@himanshus2025 himanshus2025 force-pushed the buildKernel branch 2 times, most recently from ade70ff to ec8d42c Compare November 24, 2025 18:54
@shmuelhazan shmuelhazan changed the title TG-332 Add Github action for building Linux kernel TG-332: Add Github action for building Linux kernel Nov 25, 2025
Comment on lines 22 to 30
path: |
arch/arm64/boot/Image
.config
vmlinux
Module.symvers
modules.order
arch/arm64/boot/dts
drivers
include
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe cahce all of the current dir?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also -- won't that replace also the source files?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, adding whole drivers/includes folder replace source files.
Same would happen if we, cache all of the current directory( won't be a great strategy), also it may exceed cache limit, kernel source code with build file is more than 10 GB I think.
I came up with a better solution , only caching the generated files.

@himanshus2025 himanshus2025 force-pushed the buildKernel branch 3 times, most recently from b3d7ce3 to e3128d9 Compare November 25, 2025 15:07
@himanshus2025 himanshus2025 force-pushed the buildKernel branch 4 times, most recently from 5554c59 to 5ee221f Compare November 26, 2025 12:38
@himanshus2025 himanshus2025 added ready for review label is to depict that pull request is ready for review enhancement New feature or request labels Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to remove them completely?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astrunin @himanshus2025 The reason is that currently we build the DTS as a part of the kernel. We can move it to be a part of the kernel (including the defconfig), or remove it and then build the DTBs as a part of the yocto build instead.
For now, let's keep these as empty, and @himanshus2025, can you please create a task to move the DTB/DTBO builds to be inside of yocto?
Thanks

Copy link
Author

@himanshus2025 himanshus2025 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @shmuelhazan We decided to remove them from Makefile. dtb file checks are already being taken care in Yocto.
meta-siklu-arm64/conf/machine/siklu-arm64.conf

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@himanshus2025 my bad. @astrunin corrected me that this is not needed. We can remove them from the Makefiles and from here.

Copy link

@astrunin astrunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved

@himanshus2025 himanshus2025 merged commit 4df4152 into tg-v6.12 Nov 26, 2025
1 check passed
himanshus2025 added a commit that referenced this pull request Nov 27, 2025
…ue remove ipq6018-siklu-ctu-100.dtb from Makefile) (#63)

Fix build issue i.e. removed ipq6018-siklu-ctu-100.dtb from Makefile.
Build got passed last time due to cache : here is original pull request
#61

Failure:
https://github.com/siklu/linux/actions/runs/19708155136/job/56461156967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready for review label is to depict that pull request is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants