-
Notifications
You must be signed in to change notification settings - Fork 5
TG-332: Add Github action for building Linux kernel #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb206e2 to
e7509e4
Compare
9797542 to
fbf954d
Compare
cee0d4c to
095e63a
Compare
77ea0f9 to
9a93f5e
Compare
|
Looks good to me. |
ade70ff to
ec8d42c
Compare
.github/workflows/build-kernel.yml
Outdated
| path: | | ||
| arch/arm64/boot/Image | ||
| .config | ||
| vmlinux | ||
| Module.symvers | ||
| modules.order | ||
| arch/arm64/boot/dts | ||
| drivers | ||
| include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe cahce all of the current dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also -- won't that replace also the source files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, adding whole drivers/includes folder replace source files.
Same would happen if we, cache all of the current directory( won't be a great strategy), also it may exceed cache limit, kernel source code with build file is more than 10 GB I think.
I came up with a better solution , only caching the generated files.
b3d7ce3 to
e3128d9
Compare
…ebuild cache, incase .config is changed
5554c59 to
5ee221f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not to remove them completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astrunin @himanshus2025 The reason is that currently we build the DTS as a part of the kernel. We can move it to be a part of the kernel (including the defconfig), or remove it and then build the DTBs as a part of the yocto build instead.
For now, let's keep these as empty, and @himanshus2025, can you please create a task to move the DTB/DTBO builds to be inside of yocto?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @shmuelhazan We decided to remove them from Makefile. dtb file checks are already being taken care in Yocto.
meta-siklu-arm64/conf/machine/siklu-arm64.conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@himanshus2025 my bad. @astrunin corrected me that this is not needed. We can remove them from the Makefiles and from here.
astrunin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approved
…ue remove ipq6018-siklu-ctu-100.dtb from Makefile) (#63) Fix build issue i.e. removed ipq6018-siklu-ctu-100.dtb from Makefile. Build got passed last time due to cache : here is original pull request #61 Failure: https://github.com/siklu/linux/actions/runs/19708155136/job/56461156967
Adding github action for building Linux kernel everytime , we make changes to kernel repo