DEV-7616: marvell_nand - revert to HW ECC layouts used in kernel 5.10 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e6a30d0. It also removes the check in nand_base.c which fails for some layouts after revert.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous commit (e6a30d0) that modified Marvell NAND controller hardware ECC layouts, restoring the layouts used in kernel 5.10. Additionally, it removes a strict validation check in the NAND base driver that was causing failures with some of the reverted layouts.
- Reverts ECC layout parameters in the Marvell NAND driver to kernel 5.10 values
- Removes strict ECC parameter validation that was incompatible with the reverted layouts
- Changes error handling from fatal error to warning for ECC parameter mismatches
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| drivers/mtd/nand/raw/nand_base.c | Converts strict ECC parameter validation from fatal error to warning |
| drivers/mtd/nand/raw/marvell_nand.c | Reverts ECC layout parameters to kernel 5.10 values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
paul-sirin
reviewed
Sep 22, 2025
paul-sirin
approved these changes
Sep 23, 2025
adrian-nicolau
deleted the
DEV-7616-3.4-spider-fail-to-load-3.4.0-4334-25d772ca4-stay-on-boot-after-reboot-unit-2
branch
shmuelhazan
pushed a commit
that referenced
this pull request
Nov 6, 2025
adrian-nicolau
added a commit
that referenced
this pull request
Nov 13, 2025
adrian-nicolau
added a commit
that referenced
this pull request
Nov 19, 2025
adrian-nicolau
added a commit
that referenced
this pull request
Nov 19, 2025
adrian-nicolau
added a commit
that referenced
this pull request
Nov 24, 2025
adrian-nicolau
added a commit
that referenced
this pull request
Nov 24, 2025
adrian-nicolau
added a commit
that referenced
this pull request
Nov 25, 2025
adrian-nicolau
added a commit
that referenced
this pull request
Nov 28, 2025
adrian-nicolau
added a commit
that referenced
this pull request
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e6a30d0. It also removes the check in nand_base.c which fails for some layouts after revert.