forked from gregkh/linux
-
Notifications
You must be signed in to change notification settings - Fork 5
DEV-7615: pcie-armada8k: add support for node dependencies #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adrian-nicolau
merged 4 commits into
tg-v6.12
from
adrianni-tg-v6.12-falcon-pll-pci-sync
Sep 18, 2025
Merged
DEV-7615: pcie-armada8k: add support for node dependencies #51
adrian-nicolau
merged 4 commits into
tg-v6.12
from
adrianni-tg-v6.12-falcon-pll-pci-sync
Sep 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmuelhazan
approved these changes
Sep 16, 2025
shmuelhazan
approved these changes
Sep 18, 2025
astrunin
approved these changes
Sep 18, 2025
shmuelhazan
pushed a commit
that referenced
this pull request
Nov 6, 2025
In kernel 6.12, only with `loglevel=0` boot argument, sometimes we have
modem FW asserts (ucode 0x4091 means _empty RFs_):
```
"vpp.service","dpdk [notice]: 0003:01:00.0: Firmware error detected, assert codes FW 0x00004610, UCODE 0x00004091"
```
Armada 8k has 4 x PCI: cp0_pcie0, cp0_pcie1, cp1_pcie0, cp1_pcie1. The
issue happens when they are not probed in this order, for example
cp0_pcie1, cp1_pcie0, cp1_pcie1 and only then cp0_pcie0. This PR adds
support for node dependencies, so the right order can be enforced:
```
&cp0_pcie1 {
[...]
depends-on = <&cp0_pcie0>;
};
```
At boot:
```
[ 21.784820] armada8k-pcie f2620000.pcie: deferred probe: /cp0/pcie@f2600000 not ready
[ 21.785034] armada8k-pcie f4600000.pcie: deferred probe: /cp0/pcie@f2620000 not ready
[ 21.785223] armada8k-pcie f4620000.pcie: deferred probe: /cp1/pcie@f4600000 not ready
```
adrian-nicolau
added a commit
that referenced
this pull request
Nov 13, 2025
In kernel 6.12, only with `loglevel=0` boot argument, sometimes we have
modem FW asserts (ucode 0x4091 means _empty RFs_):
```
"vpp.service","dpdk [notice]: 0003:01:00.0: Firmware error detected, assert codes FW 0x00004610, UCODE 0x00004091"
```
Armada 8k has 4 x PCI: cp0_pcie0, cp0_pcie1, cp1_pcie0, cp1_pcie1. The
issue happens when they are not probed in this order, for example
cp0_pcie1, cp1_pcie0, cp1_pcie1 and only then cp0_pcie0. This PR adds
support for node dependencies, so the right order can be enforced:
```
&cp0_pcie1 {
[...]
depends-on = <&cp0_pcie0>;
};
```
At boot:
```
[ 21.784820] armada8k-pcie f2620000.pcie: deferred probe: /cp0/pcie@f2600000 not ready
[ 21.785034] armada8k-pcie f4600000.pcie: deferred probe: /cp0/pcie@f2620000 not ready
[ 21.785223] armada8k-pcie f4620000.pcie: deferred probe: /cp1/pcie@f4600000 not ready
```
adrian-nicolau
added a commit
that referenced
this pull request
Nov 28, 2025
In kernel 6.12, only with `loglevel=0` boot argument, sometimes we have
modem FW asserts (ucode 0x4091 means _empty RFs_):
```
"vpp.service","dpdk [notice]: 0003:01:00.0: Firmware error detected, assert codes FW 0x00004610, UCODE 0x00004091"
```
Armada 8k has 4 x PCI: cp0_pcie0, cp0_pcie1, cp1_pcie0, cp1_pcie1. The
issue happens when they are not probed in this order, for example
cp0_pcie1, cp1_pcie0, cp1_pcie1 and only then cp0_pcie0. This PR adds
support for node dependencies, so the right order can be enforced:
```
&cp0_pcie1 {
[...]
depends-on = <&cp0_pcie0>;
};
```
At boot:
```
[ 21.784820] armada8k-pcie f2620000.pcie: deferred probe: /cp0/pcie@f2600000 not ready
[ 21.785034] armada8k-pcie f4600000.pcie: deferred probe: /cp0/pcie@f2620000 not ready
[ 21.785223] armada8k-pcie f4620000.pcie: deferred probe: /cp1/pcie@f4600000 not ready
```
adrian-nicolau
added a commit
that referenced
this pull request
Dec 1, 2025
In kernel 6.12, only with `loglevel=0` boot argument, sometimes we have
modem FW asserts (ucode 0x4091 means _empty RFs_):
```
"vpp.service","dpdk [notice]: 0003:01:00.0: Firmware error detected, assert codes FW 0x00004610, UCODE 0x00004091"
```
Armada 8k has 4 x PCI: cp0_pcie0, cp0_pcie1, cp1_pcie0, cp1_pcie1. The
issue happens when they are not probed in this order, for example
cp0_pcie1, cp1_pcie0, cp1_pcie1 and only then cp0_pcie0. This PR adds
support for node dependencies, so the right order can be enforced:
```
&cp0_pcie1 {
[...]
depends-on = <&cp0_pcie0>;
};
```
At boot:
```
[ 21.784820] armada8k-pcie f2620000.pcie: deferred probe: /cp0/pcie@f2600000 not ready
[ 21.785034] armada8k-pcie f4600000.pcie: deferred probe: /cp0/pcie@f2620000 not ready
[ 21.785223] armada8k-pcie f4620000.pcie: deferred probe: /cp1/pcie@f4600000 not ready
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kernel 6.12, only with
loglevel=0boot argument, sometimes we have modem FW asserts (ucode 0x4091 means empty RFs):Armada 8k has 4 x PCI: cp0_pcie0, cp0_pcie1, cp1_pcie0, cp1_pcie1. The issue happens when they are not probed in this order, for example cp0_pcie1, cp1_pcie0, cp1_pcie1 and only then cp0_pcie0. This PR adds support for node dependencies, so the right order can be enforced:
At boot: