Use process.getActiveResourcesInfo() in process metrics#485
Merged
zbjornson merged 1 commit intosiimon:masterfrom Jan 11, 2022
Merged
Conversation
Contributor
Author
|
cc @SimenB |
zbjornson
requested changes
Jan 1, 2022
Collaborator
zbjornson
left a comment
zbjornson
left a comment
There was a problem hiding this comment.
Looks great, but the tests need to be skipped in Node.js <v17 for CI to pass.
It would be great to provide upgrade guidance in the changelog since the metric name (and maybe labels?) change. (Also noting that this PR is semver major for that reason.)
RaisinTen
force-pushed
the
use-process.getActiveResourcesInfo
branch
from
52240f0 to
0711bc5
Compare
zbjornson
reviewed
Jan 9, 2022
We should use process.getActiveResourcesInfo() here because it is a public alternative of the private APIs process._getActiveHandles() and process._getActiveRequests(). Refs: https://nodejs.org/api/process.html#processgetactiveresourcesinfo Signed-off-by: Darshan Sen <[email protected]>
RaisinTen
force-pushed
the
use-process.getActiveResourcesInfo
branch
from
0711bc5 to
1fe6ef6
Compare
Collaborator
|
@RaisinTen - @cjihrig suggested that we actually keep both of these sets of metrics for now: https://twitter.com/cjihrig/status/1481433837255155717. What do you think? |
Contributor
Author
|
@zbjornson yes, I agree that we should keep both the set of metrics for now. I sent #488 to do so. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should use
process.getActiveResourcesInfo()here because it is apublic alternative of the private APIs
process._getActiveHandles()andprocess._getActiveRequests().Refs: https://nodejs.org/api/process.html#processgetactiveresourcesinfo
Signed-off-by: Darshan Sen [email protected]