Update staging-root.json and test assets#602
Merged
woodruffw merged 9 commits intosigstore:mainfrom Apr 5, 2023
Merged
Conversation
Change hardcoded root to the new root from sigstore/root-signing#756 Signed-off-by: Hayden B <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
These tests need to be updated for our new trusted root format. Testing for that is landing in sigstore#591. Signed-off-by: Andrew Pan <[email protected]>
tnytown
requested review from
jleightcap and
woodruffw
and removed request for
woodruffw
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
woodruffw
reviewed
Apr 5, 2023
woodruffw
reviewed
Apr 5, 2023
Member
woodruffw
left a comment
woodruffw
left a comment
There was a problem hiding this comment.
LGTM, one chaff file needs to be removed.
woodruffw
reviewed
Apr 5, 2023
test/unit/internal/test_tuf.py
Outdated
| ) # Valid: 1 ago, 1 ago | ||
|
|
||
|
|
||
| @pytest.mark.skip |
Contributor
Author
There was a problem hiding this comment.
This ends up exercising the TUF codepath, which doesn't return PEM keys. It's a little tricky to handle, I have helpers to make this easier to handle in #591. If we want to port stuff over from there, I can do so, although I thought it might be easier to just fix these tests in that changeset
Contributor
Author
There was a problem hiding this comment.
Oh hm I guess another option is to stub out _get_trusted_root to force the legacy non-bundled root
Member
There was a problem hiding this comment.
Oh hm I guess another option is to stub out
_get_trusted_rootto force the legacy non-bundled root
Yeah, let's do that (and document that that's what we're doing, for future software archaeologists).
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
emilejbm
pushed a commit
to emilejbm/sigstore-python
that referenced
this pull request
Apr 21, 2023
* Update staging-root.json Change hardcoded root to the new root from sigstore/root-signing#756 Signed-off-by: Hayden B <[email protected]> * wip: test: adjust local assets for staging update Signed-off-by: Andrew Pan <[email protected]> * test_tuf: skip failing getter tests These tests need to be updated for our new trusted root format. Testing for that is landing in sigstore#591. Signed-off-by: Andrew Pan <[email protected]> * fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * fixup! fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * fixup! fixup! fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * fixup! fixup! fixup! fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * test_tuf: doc Signed-off-by: Andrew Pan <[email protected]> * test: add staging-tuf targets Signed-off-by: Andrew Pan <[email protected]> --------- Signed-off-by: Hayden B <[email protected]> Signed-off-by: Andrew Pan <[email protected]> Co-authored-by: Hayden B <[email protected]> Signed-off-by: Emile Baez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #594.