Unit testing for bundled trust root getters#591
Merged
tetsuo-cpp merged 9 commits intosigstore:mainfrom Apr 10, 2023
Merged
Conversation
tnytown
added
safe to test
component:tuf
Contributor
Author
|
I was originally planning on using the staging root for this test, but sigstore/root-signing#756 is still inflight. We can cutover and update staging test assets whenever that lands. |
tnytown
force-pushed
the
andrew/issue/580
branch
from
7458d2d to
bbca128
Compare
tetsuo-cpp
reviewed
Mar 31, 2023
test/unit/internal/test_tuf.py
Outdated
| # The test should use the TUF path, so we stub out the legacy getter here. | ||
| monkeypatch.setattr(updater, "_get", lambda usage, statuses: []) | ||
|
|
||
| assert _der_keys(updater.get_ctfe_keys()) == _pem_keys([_contents("ctfe_2022.pub")]) |
Contributor
There was a problem hiding this comment.
Just so I know what to expect. When there's a key rotation, we should expect these to begin failing right? And in that case, we should refresh the keys and certs under assets/prod-tuf.
Contributor
Author
There was a problem hiding this comment.
Yep! I could alternatively monkeypatch datetime.now to return a static time, if we think that would be better :)
Contributor
Author
There was a problem hiding this comment.
also, i intend on removing assets/prod-tuf and switching to our staging assets once staging has bundled roots
Contributor
There was a problem hiding this comment.
Hmm, I'm not too bothered by it. If it becomes annoying then we can look into monkey patching the time, but for now I'd say we can switch to staging assets when it's ready and pull the trigger on this.
tnytown
added a commit
to trail-of-forks/sigstore-python
that referenced
this pull request
Apr 4, 2023
These tests need to be updated for our new trusted root format. Testing for that is landing in sigstore#591. Signed-off-by: Andrew Pan <[email protected]>
woodruffw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Update staging-root.json Change hardcoded root to the new root from sigstore/root-signing#756 Signed-off-by: Hayden B <[email protected]> * wip: test: adjust local assets for staging update Signed-off-by: Andrew Pan <[email protected]> * test_tuf: skip failing getter tests These tests need to be updated for our new trusted root format. Testing for that is landing in #591. Signed-off-by: Andrew Pan <[email protected]> * fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * fixup! fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * fixup! fixup! fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * fixup! fixup! fixup! fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * test_tuf: doc Signed-off-by: Andrew Pan <[email protected]> * test: add staging-tuf targets Signed-off-by: Andrew Pan <[email protected]> --------- Signed-off-by: Hayden B <[email protected]> Signed-off-by: Andrew Pan <[email protected]> Co-authored-by: Hayden B <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
tnytown
force-pushed
the
andrew/issue/580
branch
from
bbca128 to
9d4378b
Compare
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
tetsuo-cpp
approved these changes
Apr 10, 2023
| success[filepath] += 1 | ||
| return BytesIO(filepath.read_bytes()) | ||
| else: | ||
| print(f"POO {filepath}") |
emilejbm
pushed a commit
to emilejbm/sigstore-python
that referenced
this pull request
Apr 21, 2023
* Update staging-root.json Change hardcoded root to the new root from sigstore/root-signing#756 Signed-off-by: Hayden B <[email protected]> * wip: test: adjust local assets for staging update Signed-off-by: Andrew Pan <[email protected]> * test_tuf: skip failing getter tests These tests need to be updated for our new trusted root format. Testing for that is landing in sigstore#591. Signed-off-by: Andrew Pan <[email protected]> * fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * fixup! fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * fixup! fixup! fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * fixup! fixup! fixup! fixup! test_tuf: skip failing getter tests Signed-off-by: Andrew Pan <[email protected]> * test_tuf: doc Signed-off-by: Andrew Pan <[email protected]> * test: add staging-tuf targets Signed-off-by: Andrew Pan <[email protected]> --------- Signed-off-by: Hayden B <[email protected]> Signed-off-by: Andrew Pan <[email protected]> Co-authored-by: Hayden B <[email protected]> Signed-off-by: Emile Baez <[email protected]>
emilejbm
pushed a commit
to emilejbm/sigstore-python
that referenced
this pull request
Apr 21, 2023
* wip: test_tuf, tuf: basic bundled tests Signed-off-by: Andrew Pan <[email protected]> * tuf: use correct tlogs for rekor Signed-off-by: Andrew Pan <[email protected]> * test_tuf: test all bundled root getters Signed-off-by: Andrew Pan <[email protected]> * assets/prod-tuf: checkin Signed-off-by: Andrew Pan <[email protected]> * assets/prod-tuf: ajouter plus d'keys Signed-off-by: Andrew Pan <[email protected]> * test_tuf: reformat Signed-off-by: Andrew Pan <[email protected]> * test_tuf, conftest: staging bundled root changes Signed-off-by: Andrew Pan <[email protected]> * assets/prod-tuf: rm Signed-off-by: Andrew Pan <[email protected]> --------- Signed-off-by: Andrew Pan <[email protected]> Co-authored-by: Alex Cameron <[email protected]> Signed-off-by: Emile Baez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset exercises the bundled trusted root codepaths in
get_rekor_keys,get_ctfe_keys, andget_fulcio_certswith new offline tests. We also yakshave the TUF module further.Resolves #580.