Add a hash algorithm method to the KMS clients#1426
Draft
malancas wants to merge 20 commits intosigstore:mainfrom
Draft
Add a hash algorithm method to the KMS clients#1426malancas wants to merge 20 commits intosigstore:mainfrom
malancas wants to merge 20 commits intosigstore:mainfrom
Conversation
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Hayden-IO
reviewed
Dec 5, 2023
Contributor
Hayden-IO
left a comment
Hayden-IO
left a comment
There was a problem hiding this comment.
LGTM overall, just a question about the interface change
Signed-off-by: Meredith Lancaster <[email protected]>
Hayden-IO
approved these changes
Dec 6, 2023
Contributor
|
The failure might be due to a aws mock that needs to be updated since there are different calls being made, though i haven't looked closely. |
Contributor
Author
Agreed, I'm going to take closer look at the aws mock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opened as part of a discussion on sigstore/timestamp-authority#488, this adds a
HashFuncmethod (open to any name suggestions) to the KMS clients. This method will return the hash algorithm used with the signing key. I opened this so we could use the signing key has function in sigstore/timestamp-authority without having to pass the hash function as a flag to the server. See this PR for how the new KMS method is used in the TSA.Release Note
Documentation