Update Snapshot and Timestamp #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <[email protected]>
sigstore-bot
requested review from
bobcallaway,
haydentherapper and
kommendorkapten
| "keys": { | ||
| "25a0eb450fd3ee2bd79218c963dce3f1cc6118badf251bf149f0bd07d5cabe99": { | ||
| "keytype": "ecdsa-sha2-nistp256", | ||
| "1e1d65ce98b10addad4764febf7dda2d0436b3d3a3893579c0dddaea20e54849": { |
Member
There was a problem hiding this comment.
This is Santiago's key. The diff looks larger than it is as the order has been changed with the new key ids, so both public key (PEM encoded) and the key id is different.
| }, | ||
| "2e61cd0cbf4a8f45809bda9f7f78c0d33ad11842ff94ae340873e2664dc843de": { | ||
| "keytype": "ecdsa-sha2-nistp256", | ||
| "230e212616274a4195cdc28e9fce782c20e6c720f1a811b40f98228376bdd3ac": { |
Member
There was a problem hiding this comment.
This is the snapshot key
| }, | ||
| "45b283825eb184cabd582eb17b74fc8ed404f68cf452acabdad2ed6f90ce216b": { | ||
| "keytype": "ecdsa-sha2-nistp256", | ||
| "3c344aa068fd4cc4e87dc50b612c02431fbc771e95003993683a2b0bf260cf0e": { |
| }, | ||
| "7f7513b25429a64473e10ce3ad2f3da372bbdd14b65d07bbaf547e7c8bbbe62b": { | ||
| "keytype": "ecdsa-sha2-nistp256", | ||
| "923bb39e60dd6fa2c31e6ea55473aa93b64dd4e53e16fbe42f6a207d3f97de2d": { |
Member
There was a problem hiding this comment.
This is the timestamp key.
| }, | ||
| "e1863ba02070322ebc626dcecf9d881a3a38c35c3b41a83765b6ad6c37eaec2a": { | ||
| "keytype": "ecdsa-sha2-nistp256", | ||
| "e2f59acb9488519407e18cbfc9329510be03c04aca9929d2f0301343fec85523": { |
| }, | ||
| "f5312f542c21273d9485a49394386c4575804770667f2ddb59b3bf0669fddd2f": { | ||
| "keytype": "ecdsa-sha2-nistp256", | ||
| "ec81669734e017996c5b85f3d02c3de1dd4637a152019fe1af125d2f9368b95e": { |
| }, | ||
| "ff51e17fcf253119b7033f6f57512631da4a0969442afcf9fc8b141c7f2be99c": { | ||
| "keytype": "ecdsa-sha2-nistp256", | ||
| "fdfa83a07b5a83589b87ded41f77f39d232ad91f7cce52868dacd06ba089849f": { |
| "f5312f542c21273d9485a49394386c4575804770667f2ddb59b3bf0669fddd2f", | ||
| "7f7513b25429a64473e10ce3ad2f3da372bbdd14b65d07bbaf547e7c8bbbe62b", | ||
| "2e61cd0cbf4a8f45809bda9f7f78c0d33ad11842ff94ae340873e2664dc843de" | ||
| "3c344aa068fd4cc4e87dc50b612c02431fbc771e95003993683a2b0bf260cf0e", |
Member
There was a problem hiding this comment.
The expected keys are listed, and in targets too. For comparison look in the README for new an old key ids.
Member
|
I cross referenced all keys in root.json, by comparing looking at the new key id, which PEM encoded key it referred to, then looked at the previous key id for that and made sure it was correct, see README for the details. |
Member
./verify repository \
--repository `pwd`/repository \
--root `pwd`/repository/repository/root.json \
--targets registry.npmjs.org/keys.json,trusted_root.json
VERIFYING TUF CLIENT UPDATE
Client successfully initialized, updating and downloading targets...
Client updated to...
root.json version 9, expires 2024/09/12
timestamp.json version 166, expires 2024/03/20
snapshot.json version 130, expires 2024/04/03
targets.json version 9, expires 2024/09/12
Retrieved target registry.npmjs.org/keys.json...
{
"keys": [
... |
Member
|
Verify cosign initialization: $ ./cosign initialize --mirror http://localhost:8081 --root /Users/kommendorkapten/git/root-signing/repository/repository/5.r
oot.json
Root status:
{
"local": "/Users/kommendorkapten/.sigstore/root",
"remote": "http://localhost:8081",
"metadata": {
"root.json": {
"version": 9,
"len": 6766,
"expiration": "12 Sep 24 06:53 UTC",
"error": ""
},
"snapshot.json": {
"version": 130,
"len": 2304,
"expiration": "03 Apr 24 06:41 UTC",
"error": ""
},
"targets.json": {
"version": 9,
"len": 5478,
"expiration": "12 Sep 24 06:13 UTC",
"error": ""
},
"timestamp.json": {
"version": 166,
"len": 721,
"expiration": "20 Mar 24 06:41 UTC",
"error": ""
}
},
...And the repository side: kommendorkapten@m1m14:~/git/root-signing/repository/repository % python3 -m http.server 8081
Serving HTTP on :: port 8081 (http://[::]:8081/) ...
::1 - - [13/Mar/2024 08:05:11] "GET /6.root.json HTTP/1.1" 200 -
::1 - - [13/Mar/2024 08:05:11] "GET /7.root.json HTTP/1.1" 200 -
::1 - - [13/Mar/2024 08:05:11] "GET /8.root.json HTTP/1.1" 200 -
::1 - - [13/Mar/2024 08:05:11] "GET /9.root.json HTTP/1.1" 200 -
::1 - - [13/Mar/2024 08:05:11] code 404, message File not found
::1 - - [13/Mar/2024 08:05:11] "GET /10.root.json HTTP/1.1" 404 -
::1 - - [13/Mar/2024 08:05:11] "GET /timestamp.json HTTP/1.1" 200 -
::1 - - [13/Mar/2024 08:05:11] "GET /130.snapshot.json HTTP/1.1" 200 -
::1 - - [13/Mar/2024 08:05:11] "GET /9.targets.json HTTP/1.1" 200 - |
Member
|
I will look into the failing client tests now. |
ghost
approved these changes
Mar 13, 2024
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign snapshot and timestamp files