Replace trillian_log_server.log_id_ranges flag with a config file
#742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @lkatalin ! |
priyawadhwa
changed the title
trillian_log_server.log_id_ranges flag with a config file
priyawadhwa
force-pushed
the
refactor-config
branch
3 times, most recently
from
a0c7882 to
d066377
Compare
This will make it easier to specify mulitple shards, along with associated tree IDs and lengths. Each shard may eventually have its own signer/public key as well, so it'll be easier to pass those in through a config file rather than through CLI flags. Signed-off-by: Priya Wadhwa <[email protected]>
priyawadhwa
force-pushed
the
refactor-config
branch
from
d066377 to
7d05179
Compare
Codecov Report
@@ Coverage Diff @@
## main #742 +/- ##
==========================================
+ Coverage 47.25% 48.54% +1.28%
==========================================
Files 66 61 -5
Lines 5743 5482 -261
==========================================
- Hits 2714 2661 -53
+ Misses 2740 2534 -206
+ Partials 289 287 -2
Continue to review full report at Codecov.
|
priyawadhwa
force-pushed
the
refactor-config
branch
3 times, most recently
from
40bf8a9 to
3c5717e
Compare
Signed-off-by: Priya Wadhwa <[email protected]>
priyawadhwa
force-pushed
the
refactor-config
branch
from
3c5717e to
d63844c
Compare
Member
|
You did it!! |
dlorenc
approved these changes
Mar 22, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each shard requires the following info:
It's not easy to pass all of this in via CLI flags, so I proposed replacing
trillian_log_server.log_id_rangeswithtrillian_log_server.sharding_configwhich point to a config file in YAML for inactive shards.The active shard will still be specified by the current flags.
Summary
Ticket Link
Fixes
Release Note