Skip to content

Conversation

@adityasaky
Copy link
Member

@adityasaky adityasaky commented Sep 28, 2021

Signed-off-by: Aditya Sirish [email protected]

Summary

Switches from using github.com/in-toto/in-toto-golang/pkg/ssl to github.com/secure-systems-lab/go-securesystemslib/dsse.

Ticket Link

N/A.
See: in-toto/in-toto-golang#122

Release Note

Uses new provider for DSSE.

@adityasaky
Copy link
Member Author

I should note that we're planning to deprecate in_toto.NewSSLSigner in favour of in_toto.NewDSSESigner. Happy to submit a patch when that's live. 😄

@lukehinds
Copy link
Member

I should note that we're planning to deprecate in_toto.NewSSLSigner in favour of in_toto.NewDSSESigner. Happy to submit a patch when that's live. smile

yes please do

Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests need porting too:

tests/e2e_test.go:351:19: undefined: in_toto.PredicateProvenanceV01

https://github.com/sigstore/rekor/pull/442/checks?check_run_id=3742359781

1. Switch DSSE provider to go-securesystemslib
2. Update in-toto and use newly renamed SLSA provenance predicate

Signed-off-by: Aditya Sirish <[email protected]>
@dlorenc dlorenc merged commit 58652e3 into sigstore:main Oct 3, 2021
@adityasaky adityasaky deleted the switch-dsse-provider branch October 3, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants