Fix internal error detail leakage in 500 responses#2801
Merged
Conversation
Signed-off-by: Bob Callaway <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2801 +/- ##
===========================================
- Coverage 66.46% 26.17% -40.29%
===========================================
Files 92 191 +99
Lines 9258 20122 +10864
===========================================
- Hits 6153 5267 -886
- Misses 2359 14027 +11668
- Partials 746 828 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hayden-IO
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
err.Error()with generic constants in threehandleRekorAPIErrorcalls inentries.gothat were exposing internal error details (gRPC status text, hostnames, file paths) to unauthenticated callers via 500 response bodiesDetailed errors are still logged server-side; only the user-facing message changes