Skip to content

use interruptable context to elegantly handle signals in rekor-cli#2681

Merged
bobcallaway merged 1 commit intosigstore:mainfrom
bobcallaway:command-signal
Nov 14, 2025
Merged

use interruptable context to elegantly handle signals in rekor-cli#2681
bobcallaway merged 1 commit intosigstore:mainfrom
bobcallaway:command-signal

Conversation

@bobcallaway
Copy link
Copy Markdown
Member

also cleans up some left-over build tags which aren't compliant with new compilers.

@bobcallaway bobcallaway requested a review from a team as a code owner November 14, 2025 17:12
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.16%. Comparing base (488eb97) to head (e2b80a4).
⚠️ Report is 574 commits behind head on main.

Files with missing lines Patch % Lines
cmd/rekor-cli/app/log_proof.go 0.00% 2 Missing ⚠️
cmd/rekor-cli/app/root.go 66.66% 0 Missing and 1 partial ⚠️
cmd/rekor-cli/app/upload.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2681       +/-   ##
===========================================
- Coverage   66.46%   26.16%   -40.30%     
===========================================
  Files          92      191       +99     
  Lines        9258    20128    +10870     
===========================================
- Hits         6153     5266      -887     
- Misses       2359    14033    +11674     
- Partials      746      829       +83     
Flag Coverage Δ
e2etests 49.68% <88.57%> (+2.12%) ⬆️
unittests 16.68% <0.00%> (-31.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobcallaway bobcallaway merged commit e032725 into sigstore:main Nov 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants