restapi: Don't log client errors as errors#2680
Merged
Hayden-IO merged 1 commit intosigstore:mainfrom Nov 11, 2025
Merged
Conversation
Member
jku
commented
Nov 11, 2025
jku
commented
- 400-499 should be logged as warning at most
- The logged error should include the code: otherwise it's often a cryptic string that does not clearly say if it's a client issue or no.
* 400-499 should be logged as warning at most
* The logged error should include the code: otherwise it's often a
cryptic string that does not really say if it's a client issue or no.
Example:
ERRROR: validation failure list: hash in body should match '^(sha512:)?[0-9a-fA-F]{128}$|^(sha256:)?[0-9a-fA-F]{64}$|^(sha1:)?[0-9a-fA-F]{40}$'
Signed-off-by: Jussi Kukkonen <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2680 +/- ##
===========================================
- Coverage 66.46% 26.15% -40.31%
===========================================
Files 92 191 +99
Lines 9258 20126 +10868
===========================================
- Hits 6153 5264 -889
- Misses 2359 14033 +11674
- Partials 746 829 +83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hayden-IO
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.