e2e: don't mix e2e and regular utilities#2672
Merged
Hayden-IO merged 1 commit intosigstore:mainfrom Nov 5, 2025
Merged
Conversation
E2E utilities should be only defined in test files and should not be mixed with the common function in pkg/util. Go modules/vendoring makes no filtering based on build tags and so all the dependencies needed for E2E become dependencies to any package that internally imports pkg/util. Signed-off-by: Tonis Tiigi <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
===========================================
- Coverage 66.46% 26.12% -40.34%
===========================================
Files 92 191 +99
Lines 9258 20112 +10854
===========================================
- Hits 6153 5254 -899
- Misses 2359 14029 +11670
- Partials 746 829 +83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hayden-IO
reviewed
Nov 5, 2025
Contributor
Hayden-IO
left a comment
Hayden-IO
left a comment
There was a problem hiding this comment.
Thank you again for cleaning all of this up!
Hayden-IO
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separate utilities and test data made exclusively for E2E testing from other packages.
E2E utilities should be only used in test files and should not be defined mixed with the common functions in pkg/util. Go modules/vendoring makes no filtering based on build tags and so all the dependencies needed for E2E become dependencies to any package that internally imports pkg/util.
Release Note
Documentation