use less expensive gRPC call to implement GetLeafAndProofByHash#2581
Merged
bobcallaway merged 2 commits intosigstore:mainfrom Aug 14, 2025
Merged
Conversation
Signed-off-by: Bob Callaway <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2581 +/- ##
===========================================
- Coverage 66.46% 24.98% -41.48%
===========================================
Files 92 190 +98
Lines 9258 24527 +15269
===========================================
- Hits 6153 6129 -24
- Misses 2359 17612 +15253
- Partials 746 786 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hayden-IO
previously approved these changes
Aug 13, 2025
Signed-off-by: Bob Callaway <[email protected]>
Hayden-IO
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #2580,
GetLeafAndProofByHashneeds to call two Trillian endpoints:GetInclusionProofByHashto get the indexWe were previously calling
GetEntryAndProofviaGetLeafAndProofByIndexbut since we already have the proof fromGetInclusionProofByHash, this is a cheaper sequence of calls for Trillian with equivalent functionality.