move to per-shard trillian client manager#2564
Merged
bobcallaway merged 6 commits intosigstore:mainfrom Aug 13, 2025
Merged
Conversation
Signed-off-by: Bob Callaway <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2564 +/- ##
===========================================
- Coverage 66.46% 24.99% -41.47%
===========================================
Files 92 190 +98
Lines 9258 24500 +15242
===========================================
- Hits 6153 6123 -30
- Misses 2359 17595 +15236
- Partials 746 782 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Hayden-IO
previously approved these changes
Aug 13, 2025
Contributor
Hayden-IO
left a comment
Hayden-IO
left a comment
There was a problem hiding this comment.
Looks good overall! As long as we thoroughly test this against both active and inactive shards, seems good.
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Hayden-IO
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows users to configure a different trillian gRPC backend per-shard instead of assuming all shards are hosted by the same trillian instance. It is backwards compatible (if only the base level values for
trillian-log-server.{address, port, tls, tls_ca_cert}are specified, they are used for all shards unless overridden in the shard config).include some other minor fixes: