Skip to content

return NotFound if treesize is 0 rather than calling trillian#1311

Merged
bobcallaway merged 1 commit intosigstore:mainfrom
bobcallaway:issue_1308
Jan 31, 2023
Merged

return NotFound if treesize is 0 rather than calling trillian#1311
bobcallaway merged 1 commit intosigstore:mainfrom
bobcallaway:issue_1308

Conversation

@bobcallaway
Copy link
Copy Markdown
Member

Fixes: #1308

Signed-off-by: Bob Callaway [email protected]

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 28, 2023

Codecov Report

Merging #1311 (c8e8529) into main (18c81d9) will increase coverage by 0.18%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
+ Coverage   63.22%   63.40%   +0.18%     
==========================================
  Files          82       82              
  Lines        7863     7869       +6     
==========================================
+ Hits         4971     4989      +18     
+ Misses       2260     2253       -7     
+ Partials      632      627       -5     
Flag Coverage Δ
e2etests 46.88% <100.00%> (+0.14%) ⬆️
unittests 42.93% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/trillian_client.go 67.02% <100.00%> (+0.72%) ⬆️
pkg/api/entries.go 63.99% <0.00%> (-0.66%) ⬇️
pkg/types/helm/v0.0.1/entry.go 49.18% <0.00%> (ø)
pkg/types/alpine/v0.0.1/entry.go 74.10% <0.00%> (+2.39%) ⬆️
cmd/rekor-cli/app/log_info.go 60.00% <0.00%> (+5.00%) ⬆️
cmd/rekor-cli/app/state/state.go 61.81% <0.00%> (+5.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cpanato cpanato requested a review from asraa January 28, 2023 11:52
@bobcallaway bobcallaway merged commit b446717 into sigstore:main Jan 31, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getProofByHash returns InvalidArgument if log is empty instead of NotFound

5 participants