Conversation
jku
force-pushed
the
manage-python-version
branch
from
f260d82 to
e396e9c
Compare
jku
force-pushed
the
manage-python-version
branch
from
e396e9c to
fde8204
Compare
Member
Author
|
I think this works and is better than the other PR: This one actually solves the linked issues by managing the Python internally. Marked ready for review |
* Add script for creating venvs in a way that * uses uv without requiring it to be installed * controls the used Python version with .python-version file * Use the script in Makefile and action setup * Be sure to treat Windows as the special case it is with regards to venv bin directory Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
manage-python-version
branch
from
fde8204 to
6ce7f53
Compare
woodruffw
approved these changes
Nov 3, 2025
Member
woodruffw
left a comment
woodruffw
left a comment
There was a problem hiding this comment.
LGTM!
(I would be okay with us having a hard dependency on uv, for the record. But I'm also okay with this kind of bootstrapping 🙂)
anishnaik
added a commit
to crytic/medusa
that referenced
this pull request
Dec 2, 2025
Updates sigstore/gh-action-sigstore-python from v3.1.0 to the latest commit on main branch. This includes the fix from PR #242 which resolves Python version management issues on Windows runners. The action now creates its own venv internally using uv and manages Python versions independently, fixing the dnspython 2.8.0 installation error that occurred on Windows runners with Python 3.9. Reference: sigstore/gh-action-sigstore-python#242 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
7 tasks
anishnaik
added a commit
to crytic/medusa
that referenced
this pull request
Dec 2, 2025
* ci: update sigstore action to fix Windows Python compatibility Updates sigstore/gh-action-sigstore-python from v3.1.0 to the latest commit on main branch. This includes the fix from PR #242 which resolves Python version management issues on Windows runners. The action now creates its own venv internally using uv and manages Python versions independently, fixing the dnspython 2.8.0 installation error that occurred on Windows runners with Python 3.9. Reference: sigstore/gh-action-sigstore-python#242 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * upgrade to v1.4.1 --------- Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this fixes #235 and #236 (by controlling the used python version in the venv we use, currently set to 3.14). Also makes #238 not needed.