Conversation
* Argument is optional, valid values [1,2] * Default is 1, except on staging where it's 2 * Plan is to change default to 2 in a major release as soon as Rekor v2 is available in production Signed-off-by: Jussi Kukkonen <[email protected]>
Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
rekor-version-argument
branch
from
aa0c498 to
c394ac5
Compare
Merged
woodruffw
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #227
It's worth noting that this means we always set
--rekor-versionnow. The annoying part of that is that settingrekor-version:2right now fails in production (because it's not defined in signingconfig yet)... but I don't want to make that an invalid input since it will start succeeding at some point, and I'm also hesitant to add more complexity likerekor-version: autoor something. I think I'm fine with this: after all, most users should never have to touch this argument.