use standard GitHub Actions debugging#150
Closed
rindeal wants to merge 1 commit intosigstore:mainfrom
Closed
Conversation
I don't see the need for wheel reinvention. https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging Signed-off-by: Jan Chren ~rindeal <[email protected]>
Member
|
This is an internal option that we explicitly don't document as part of a public API. The reason it doesn't use the built-in actions debugging state is because that state requires the user to change a workflow-level variable or secret, which both requires a larger context switch (moving from the editor to the repo's settings on GitHub) and also assumes that workflow re-runs are idempotent (which in the context of release signing, they typically aren't). TL;DR: There's a reason this is done the way it is. I'd be happy to review a PR that adapts the current setting to also take |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I don't see the need for wheel reinvention.
https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
The workflow after this change is basically: if a job fails, you re-run it with debugging enabled and see all the debug logs.
Release Note
NONE
Documentation
NONE