Skip to content

Comments

action: flip release-signing-artifacts#142

Merged
jku merged 1 commit intomainfrom
ww/flip
Jul 8, 2024
Merged

action: flip release-signing-artifacts#142
jku merged 1 commit intomainfrom
ww/flip

Conversation

@woodruffw
Copy link
Member

This was another pre-3.0 task.

Closes #45.

@woodruffw woodruffw added the enhancement New feature or request label Jun 17, 2024
@woodruffw woodruffw added this to the 3.0 milestone Jun 17, 2024
@woodruffw woodruffw requested a review from jku June 17, 2024 15:08
@woodruffw woodruffw self-assigned this Jun 17, 2024
woodruffw added a commit that referenced this pull request Jun 17, 2024
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw mentioned this pull request Jun 17, 2024
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jku jku merged commit 16fbe9a into main Jul 8, 2024
@jku jku deleted the ww/flip branch July 8, 2024 15:50
DK96-OS added a commit to DK96-OS/gh-action-sigstore-python that referenced this pull request Dec 3, 2024
(sigstore#134):
* schedule-selftest: reduce nagging
---------
Signed-off-by: William Woodruff <[email protected]>

(sigstore#140):
* requirements: sigstore ~3.0
* selftest: update filenames
* action: update another path
* action: remove deprecated settings
* README: remove old docs
---------
Signed-off-by: William Woodruff <[email protected]>

(sigstore#145):
* action: use a venv to prevent PEP 668 errors
* action: use sys.executable
* fight with Windows
* setup: minimum Python is 3.8 (This has been true for a while)
---------
Signed-off-by: William Woodruff <[email protected]>

(sigstore#142):
* action: flip `release-signing-artifacts`
---------
Signed-off-by: William Woodruff <[email protected]>

(sigstore#146):
* action: remove old output settings
* selftest: remove old test ref
---------
Signed-off-by: William Woodruff <[email protected]>

Cleanup workflows (sigstore#148):
* Workflows: remove default input arg from action call
* workflows: Remove unnecessary selftest

release-signing-artifacts defaults to "true" so the removed test now
duplicates the previous test.

We could try testing the release-signing-artifacts == "false" but that's
a bit trickier since it could only be done in a release event...

* workflows: Drop recently removed job from needs-list
---------
Signed-off-by: Jussi Kukkonen <[email protected]>

Prep 3.0.0 (sigstore#143):
---------
Signed-off-by: William Woodruff <[email protected]>

(sigstore#152):
* build(deps): bump peter-evans/create-issue-from-file from 5.0.0 to 5.0.1 in the actions group
---------
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

(sigstore#154):
* Fix remaining reference to 2.1.1 in README
---------
Signed-off-by: Stefanie Molin <[email protected]>

(sigstore#151):
* Enable debugging also if ACTIONS_STEP_DEBUG==true
---------
Co-authored-by: rindeal <[email protected]>
Co-authored-by: William Woodruff <[email protected]>

Upgrade Dependencies:
* Update requirements.txt - upgrade sigstore 3.1, upgrade requests 2.32
---------
Signed-off-by: DK96-OS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flip the release-signing-artifacts default

2 participants