Register /healthz endpoint when listening on duplex http/grpc port
#2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registers the `/healthz` endpoint when listening on a duplex http/grpc port, just like the `http` port does when running in non-duplex mode. The current helm charts use this endpoint for the liveness and readiness probes, so I'm assuming this should be exposed even when HTTP and gRPC are listening on the same port. Signed-off-by: Kevin Davis <[email protected]>
Hayden-IO
reviewed
May 14, 2025
Contributor
Hayden-IO
left a comment
Hayden-IO
left a comment
There was a problem hiding this comment.
Thanks so much for catching and fixing this!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2046 +/- ##
===========================================
- Coverage 57.93% 43.37% -14.56%
===========================================
Files 50 72 +22
Lines 3119 5671 +2552
===========================================
+ Hits 1807 2460 +653
- Misses 1154 2987 +1833
- Partials 158 224 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kevin Davis <[email protected]>
lukehinds
approved these changes
May 24, 2025
Hayden-IO
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Registers the
/healthzendpoint when listening on a duplex http/grpc port, just like thehttpport does when running in non-duplex mode.The current helm charts use this endpoint for the liveness and readiness probes, so I'm assuming this should be exposed even when HTTP and gRPC are listening on the same port.
Fixes #2047
Release Note