Remove dependency on github.com/pkg/errors #3956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Soyland <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3956 +/- ##
==========================================
- Coverage 40.10% 36.38% -3.73%
==========================================
Files 155 209 +54
Lines 10044 13383 +3339
==========================================
+ Hits 4028 4869 +841
- Misses 5530 7889 +2359
- Partials 486 625 +139 ☔ View full report in Codecov by Sentry. |
codysoyland
commented
Dec 10, 2024
| func idToken(s string) (string, error) { | ||
| // If this is a valid raw token or is empty, just return it | ||
| if _, err := jose.ParseSigned(s); err == nil || s == "" { | ||
| if _, err := jwt.ParseSigned(s); err == nil || s == "" { |
Member
Author
There was a problem hiding this comment.
I forgot to mention it in the PR description, but the reason I replaced go.step.sm/crypto/jose with github.com/go-jose/go-jose/v3/jwt is that the former is a wrapper around the latter (that we don't benefit from) and includes references to the github.com/pkg/errors package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cody Soyland [email protected]
Summary
This removes the deprecated
github.com/pkg/errorspackage, which has been replaced by the standard library. This work was previously done in #1887, but several invocations have been gradually added since then.Fixes #1880 again :)
Release Note
Documentation