feat: Use remote.Reuse to make everything faster#2929
Merged
znewman01 merged 1 commit intosigstore:mainfrom Apr 25, 2023
Merged
feat: Use remote.Reuse to make everything faster#2929znewman01 merged 1 commit intosigstore:mainfrom
znewman01 merged 1 commit intosigstore:mainfrom
Conversation
Previously, every call to a remote.Function was performing a Ping and Token exchange, which meant that we were doing 3 round trips instead of 1 (for most calls). The remote.Reuse option effectively tells the remote package to call methods on a Pusher/Puller instance rather than re-doing the Ping and Token requests. The alternative to this PR would be to plumb around a puller and pusher instance and refactor all of cosign to call methods on those, but this is much simpler. Signed-off-by: Jon Johnson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2929 +/- ##
==========================================
- Coverage 30.33% 30.32% -0.01%
==========================================
Files 151 151
Lines 9439 9451 +12
==========================================
+ Hits 2863 2866 +3
- Misses 6134 6140 +6
- Partials 442 445 +3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattmoor
approved these changes
Apr 25, 2023
SantiagoTorres
approved these changes
Apr 25, 2023
jonjohnsonjr
added a commit
to jonjohnsonjr/apko
that referenced
this pull request
Apr 25, 2023
This is a first pass at speeding up the registry portion of apko publish. Currently draft until this lands in cosign: sigstore/cosign#2929
jonjohnsonjr
added a commit
to jonjohnsonjr/apko
that referenced
this pull request
Apr 25, 2023
This is a first pass at speeding up the registry portion of apko publish. Currently draft until this lands in cosign: sigstore/cosign#2929 Signed-off-by: Jon Johnson <[email protected]>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuing #2901
Previously, every call to a remote.Function was performing a Ping and Token exchange, which meant that we were doing 3 round trips instead of 1 (for most calls).
The remote.Reuse option effectively tells the remote package to call methods on a Pusher/Puller instance rather than re-doing the Ping and Token requests.
The alternative to this PR would be to plumb around a puller and pusher instance and refactor all of cosign to call methods on those, but this is much simpler.
For an empty destination repository,
cosign copyimproved from 24s to 19s. When re-running it against a repository we already pushed to, we see improvement from ~12s to ~3.5s.cosign copy gcr.io/projectsigstore/cosign:v1.13.0 (before)cosign copy gcr.io/projectsigstore/cosign:v1.13.0 (after)Release Note
cosignregistry operations were optimized to be much faster.Documentation