Resolves sigstore/community#121#2263
Merged
dlorenc merged 2 commits intosigstore:mainfrom Sep 19, 2022
Merged
Conversation
* add paths to all needed workflows * fixing action versions * remove whitespace Signed-off-by: n3k0m4 <[email protected]>
Signed-off-by: n3k0m4 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2263 +/- ##
==========================================
+ Coverage 28.40% 28.56% +0.15%
==========================================
Files 131 131
Lines 7832 7855 +23
==========================================
+ Hits 2225 2244 +19
+ Misses 5309 5305 -4
- Partials 298 306 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
cc @cpanato |
cpanato
approved these changes
Sep 19, 2022
Member
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
looks cool! thanks for working on this!
Contributor
Author
|
Thanks. Looking forward to contributing more to the code base and Sigstore's projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR solves the Sigstore community issue #121 for Cosign.
To summarize the issue, all the Sigstore projects were running multiple workflows (unit & e2e tests, builds, ...) even when the changes were unimportant (.txt, .md, ...). This causes unnecessary use of resources.
The solution implemented in this PR is adding paths matching for the files that can trigger the execution of workflows.
Testing:
There are potentially two ways to test these changes:
Forking the repository and executing the steps below, or making a new branch in the current repo and adding the branch name in
branches:inside the modified workflows, then executing the steps below..md,.txtor other file in paths likeimagesordocResults: No actions should run.
Release Note
Documentation