Skip to content

Conversation

@k4leung4
Copy link
Contributor

@k4leung4 k4leung4 commented Aug 18, 2022

Signed-off-by: Kenny Leung [email protected]

Summary

this updates the fulcio dep from 0.1.2 to 0.5.2.

api.Client => api.LegacyClient

io/ioutil deprecated in go 1.16, use corresponding replacement in io and os

Release Note

NONE

Documentation

@k4leung4 k4leung4 requested a review from cpanato August 18, 2022 16:24
@k4leung4 k4leung4 marked this pull request as draft August 18, 2022 16:51
@k4leung4 k4leung4 removed the request for review from cpanato August 18, 2022 16:51
cpanato
cpanato previously approved these changes Aug 18, 2022
Signed-off-by: Kenny Leung <[email protected]>
Signed-off-by: Kenny Leung <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.70%. Comparing base (8f29f03) to head (695b2c6).
⚠️ Report is 1493 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/fulcio/fulcio.go 66.66% 1 Missing ⚠️
cmd/cosign/cli/options/registry.go 0.00% 1 Missing ⚠️
pkg/cosign/fetch.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
+ Coverage   26.03%   26.70%   +0.66%     
==========================================
  Files         131      131              
  Lines        7689     7689              
==========================================
+ Hits         2002     2053      +51     
+ Misses       5445     5375      -70     
- Partials      242      261      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Kenny Leung <[email protected]>
Signed-off-by: Kenny Leung <[email protected]>
@k4leung4 k4leung4 marked this pull request as ready for review August 21, 2022 01:44
@dlorenc dlorenc merged commit 7ba5214 into sigstore:main Aug 22, 2022
@github-actions github-actions bot added this to the v1.12.0 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants