Add Tempo tracing backend to collect span data #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2025
michaelsproul
approved these changes
Jul 31, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM, but haven't had a chance to test yet
jimmygchen
commented
Aug 1, 2025
tempo.yaml
Outdated
Comment on lines
33
to
35
| max_bytes_per_trace: 1000000000 # ~100 MB per trace limit | ||
| ingestion_rate_limit_bytes: 60000000 # 60MB/sec | ||
| ingestion_burst_size_bytes: 120000000 # 120MB burst No newline at end of file |
Member
Author
There was a problem hiding this comment.
Oh i should revisit these overrides, this shouldn't be needed now we've removed all the old spans.
Member
Author
There was a problem hiding this comment.
I've commented them out, and it still accepts the new spans I added.
Looks like the old spans were too big and causing issues here. I'll keep them here in case we run into the issue and need them again to debug.
jimmygchen
commented
Aug 8, 2025
Comment on lines
+26
to
+30
| - client | ||
| - result | ||
| - non_custody_indices | ||
| - imported_blocks | ||
| - missing_column_indexes |
Member
Author
There was a problem hiding this comment.
These are the fields that gets added as labels in the generated metrics for query purpose.
mergify bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Aug 8, 2025
#7815 - removes all existing spans, so some span fields that appear in logs like `service_name` may be lost. - instruments a few key code paths in the beacon node, starting from **root spans** named below: * Gossip block and blobs * `process_gossip_data_column_sidecar` * `process_gossip_blob` * `process_gossip_block` * Rpc block and blobs * `process_rpc_block` * `process_rpc_blobs` * `process_rpc_custody_columns` * Rpc blocks (range and backfill) * `process_chain_segment` * `PendingComponents` lifecycle * `pending_components` To test locally: * Run Grafana and Tempo with sigp/lighthouse-metrics#57 * Run Lighthouse BN with `--telemetry-collector-url http://localhost:4317` Some captured traces can be found here: https://hackmd.io/@jimmygchen/r1sLOxPPeg Removing the old spans seem to have reduced the memory usage quite a lot - i think we were using them on long running tasks and too excessively: <img width="910" height="495" alt="image" src="https://github.com/user-attachments/assets/5208bbe4-53b2-4ead-bc71-0b782c788669" />
Member
|
Shall we merge this? |
Member
Author
Yes let's merge this. I've been using this setup for a while with no issues. (i don't have merge rights to this repo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.