Skip to content

Implement /lighthouse/custody/info API #8276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 6 commits into from
Oct 27, 2025
Merged

Implement /lighthouse/custody/info API #8276

mergify merged 6 commits into from
Oct 27, 2025

Conversation

@michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Oct 23, 2025 •
edited
Loading

Issue Addressed

Closes:

Proposed Changes

New /lighthouse/custody API including:

  • Earliest custodied data column slot
  • Node CGC
  • Custodied columns

Additional Info

Aiming for inclusion in v8.0.0 but not v8.0.0-rc.2

Needs:

  • Client code in eth2
  • Test

@michaelsproul michaelsproul added HTTP-API das Data Availability Sampling v8.0.0 Q4 2025 Fusaka Mainnet Release labels Oct 23, 2025
@michaelsproul michaelsproul changed the title Start on the /lighthouse/custody API Implement /lighthouse/custody API Oct 23, 2025
@michaelsproul michaelsproul changed the title Implement /lighthouse/custody API Implement /lighthouse/custody/info API Oct 27, 2025
@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Oct 27, 2025
jimmygchen
jimmygchen approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like having the logic in a separate file from lib.rs.

I think it's worth adding this endpoint to the book?
https://github.com/sigp/lighthouse/blob/11bcccb353c073ab6d23690d0fd3a3b8940d8e95/book/src/api_lighthouse.md

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 27, 2025
@mergify mergify bot added the queued label Oct 27, 2025
mergify bot added a commit that referenced this pull request Oct 27, 2025
@mergify
Merge of #8276
0ddf51d
@mergify mergify bot mentioned this pull request Oct 27, 2025
Closed
10 tasks
@chong-he
Copy link
Member

chong-he commented Oct 27, 2025 •
edited
Loading

Looks great! I like having the logic in a separate file from lib.rs.

I think it's worth adding this endpoint to the book? https://github.com/sigp/lighthouse/blob/11bcccb353c073ab6d23690d0fd3a3b8940d8e95/book/src/api_lighthouse.md

I was thinking about this and maybe I can add this endpoint to the PR #8284 ? (as this PR is queued for merge now)

edit: nvm, 8284 also queued for merge now 😅

mergify bot added a commit that referenced this pull request Oct 27, 2025
@mergify
Merge of #8276
7152ebc
@mergify mergify bot merged commit d67ae92 into unstable Oct 27, 2025
37 checks passed
@mergify mergify bot deleted the custody-info-api branch October 27, 2025 08:48
@mergify mergify bot removed the queued label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees

No one assigned

Labels

das Data Availability Sampling HTTP-API ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelsproul @chong-he @jimmygchen