Remove redundant subscribe_all_data_column_subnets field from network
#8259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pawanjay176 <[email protected]>
… validator should have `validator_custody_at_head` set to 0.
jimmygchen
added
code-quality
ready-for-review
jimmygchen
force-pushed
the
semi-supernode-simple-cleanup
branch
from
f3a3e2a to
029ba13
Compare
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
dapplion
approved these changes
Oct 27, 2025
Collaborator
There was a problem hiding this comment.
LGTM!
@jimmygchen this commit fixes the failing test 4084d11
Co-Authored-By: dapplion <[email protected]>
jimmygchen
force-pushed
the
semi-supernode-simple-cleanup
branch
from
fe778b3 to
c19e963
Compare
Member
Author
|
@dapplion thanks for the fix, I've pushed your changes. |
jimmygchen
added
ready-for-merge
6 tasks
eserilev
pushed a commit
to eserilev/lighthouse
that referenced
this pull request
Oct 30, 2025
…rk (sigp#8259) Addresses this comment: sigp#8254 (comment) We're currently using `subscribe_all_data_column_subnets` here to subscribe to all subnets https://github.com/sigp/lighthouse/blob/522bd9e9c6ac167f2231525e937c9ebbcb86cf6e/beacon_node/lighthouse_network/src/types/topics.rs#L82-L92 But its unnecessary because the else path also works for supernode (uses `sampling_subnets` instead) The big diffs will disappear once sigp#8254 is merged. Co-Authored-By: Jimmy Chen <[email protected]>
eserilev
pushed a commit
to eserilev/lighthouse
that referenced
this pull request
Oct 30, 2025
…rk (sigp#8259) Addresses this comment: sigp#8254 (comment) We're currently using `subscribe_all_data_column_subnets` here to subscribe to all subnets https://github.com/sigp/lighthouse/blob/522bd9e9c6ac167f2231525e937c9ebbcb86cf6e/beacon_node/lighthouse_network/src/types/topics.rs#L82-L92 But its unnecessary because the else path also works for supernode (uses `sampling_subnets` instead) The big diffs will disappear once sigp#8254 is merged. Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses this comment: #8254 (comment)
We're currently using
subscribe_all_data_column_subnetshere to subscribe to all subnetslighthouse/beacon_node/lighthouse_network/src/types/topics.rs
Lines 82 to 92 in 522bd9e
But its unnecessary because the else path also works for supernode (uses
sampling_subnetsinstead)The big diffs will disappear once #8254 is merged.