Skip to content

Add version to the response of beacon API getPendingConsolidations #8251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 2 commits into from
Oct 21, 2025
Merged

Add version to the response of beacon API getPendingConsolidations #8251

mergify merged 2 commits into from
Oct 21, 2025

Conversation

@chong-he
Copy link
Member

@chong-he chong-he commented Oct 21, 2025

Issue Addressed

Additional Info

Tested to confirm it works:

Before:
{"execution_optimistic":true,"finalized":false,"data":[]}

After:
{"version":"electra","execution_optimistic":true,"finalized":false,"data":[]}

@chong-he chong-he added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! HTTP-API labels Oct 21, 2025
michaelsproul
michaelsproul requested changes Oct 21, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind updating the test for this endpoint too? Just to assert something about the returned version. Might need to update the HTTP client code in common/eth2 as well

@michaelsproul michaelsproul added the v8.0.0 Q4 2025 Fusaka Mainnet Release label Oct 21, 2025
jimmygchen added a commit that referenced this pull request Oct 21, 2025
@jimmygchen
Add version to the response of beacon API getPendingConsolidations (#…
b1e4531 
…8251)

Squashed commit of the following:

commit 3ef9c9d
Author: Tan Chee Keong <[email protected]>
Date:   Tue Oct 21 11:13:48 2025 +0800

    add version
@jimmygchen jimmygchen mentioned this pull request Oct 21, 2025
Merged
@chong-he
Copy link
Member Author

chong-he commented Oct 21, 2025 •
edited
Loading

Do you mind updating the test for this endpoint too? Just to assert something about the returned version. Might need to update the HTTP client code in common/eth2 as well

Added a test in 32061c9

It seems that the pending_deposits and pending_partial_withdrawals endpoints do not return the version on the client side (server side is ok):

lighthouse/common/eth2/src/lib.rs

Lines 904 to 918 in e5b4983

pub async fn get_beacon_states_pending_deposits(
&self,
state_id: StateId,
) -> Result<Option<ExecutionOptimisticFinalizedResponse<Vec<PendingDeposit>>>, Error> {
let mut path = self.eth_path(V1)?;
path.path_segments_mut()
.map_err(|()| Error::InvalidUrl(self.server.clone()))?
.push("beacon")
.push("states")
.push(&state_id.to_string())
.push("pending_deposits");
self.get_opt(path).await
}

It's returning ExecutionOptimisticFinalizedResponse instead of ExecutionOptimisticFinalizedBeaconResponse that contains the version info. Should we open an issue about this? (seeing that rc.2 is imminent and want to minimize changes)

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 21, 2025
@mergify mergify bot added the queued label Oct 21, 2025
mergify bot added a commit that referenced this pull request Oct 21, 2025
@mergify
Merge of #8251
4a2d5b5
@mergify mergify bot mentioned this pull request Oct 21, 2025
Closed
10 tasks
@mergify mergify bot merged commit 040d992 into sigp:unstable Oct 21, 2025
37 checks passed
@mergify mergify bot removed the queued label Oct 21, 2025
@jimmygchen jimmygchen mentioned this pull request Oct 22, 2025
Closed
mergify bot pushed a commit that referenced this pull request Oct 23, 2025
@jimmygchen
Release v8.0.0 rc.2 (#8255)
b59feb0 
Open PRs to include for the release
- #7907
- #8247
- #8251
- #8253
- #8254
- #8265
- #8269
- #8266


  


Co-Authored-By: Jimmy Chen <[email protected]>

Co-Authored-By: Jimmy Chen <[email protected]>
@chong-he chong-he deleted the pending-consolidation-version branch October 27, 2025 23:47
@chong-he chong-he mentioned this pull request Oct 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees

No one assigned

Labels

HTTP-API low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chong-he @michaelsproul